frankvicky commented on code in PR #16156:
URL: https://github.com/apache/kafka/pull/16156#discussion_r1622619577
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -298,7 +298,7 @@ private void sendUnsentRequests(final Timer timer) {
do {
Review Comment:
Cool, I think we don't need this early return statement in the current
situation because we also need to consider if there are any in-flight requests.
The reason why we have this statement here is because we didn't consider the
in-flight requests before, so we could return if there are no unsent requests.
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
