philipnee commented on code in PR #16124:
URL: https://github.com/apache/kafka/pull/16124#discussion_r1623646783
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -483,6 +483,23 @@ public void resetTimer() {
this.heartbeatTimer.reset(heartbeatIntervalMs);
}
+ @Override
+ public String toStringBase() {
+ return super.toStringBase() +
+ ", heartbeatTimer=" + heartbeatTimer +
+ ", heartbeatIntervalMs=" + heartbeatIntervalMs;
+ }
+
+ // Visible for testing
Review Comment:
i don't think we need the `heartbeatTimer()` and `heartbeatIntervalMs()`
here. see the comment below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
