philipnee commented on code in PR #16124:
URL: https://github.com/apache/kafka/pull/16124#discussion_r1623646860
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -152,6 +152,34 @@ public void cleanup() {
}
}
+ @Test
+ public void testHeartBeatRequestStateToStringBase() {
+ final long retryBackoffMs = 100;
Review Comment:
i think we should try to consistently apply final to all variables if we
want to use final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]