mimaison commented on code in PR #15834:
URL: https://github.com/apache/kafka/pull/15834#discussion_r1624282626


##########
core/src/main/scala/kafka/server/KafkaConfig.scala:
##########
@@ -1457,6 +1465,18 @@ class KafkaConfig private(doLog: Boolean, val props: 
java.util.Map[_, _], dynami
     }
   }
 
+  /**
+   * Validate some configurations for new MetadataVersion. A new 
MetadataVersion can take place when
+   * a FeatureLevelRecord for "metadata.version" is read from the cluster 
metadata.
+   */
+  def validateWithMetadataVersion(metadataVersion: MetadataVersion): Unit = {

Review Comment:
   Ah right, thanks for the explanation. Then I guess it makes sense to keep 
both methods for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to