soarez commented on code in PR #15834:
URL: https://github.com/apache/kafka/pull/15834#discussion_r1626025676


##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -45,89 +45,124 @@ import scala.jdk.CollectionConverters._
 import scala.collection.mutable.ArrayBuffer
 
 object StorageTool extends Logging {
+
+  /**
+   * Executes the command according to the given arguments and returns the 
appropriate exit code.
+   * @param args The command line arguments
+   * @return     The exit code
+   */
+  def runMain(args: Array[String]): Int = {
+    val namespace = parseArguments(args)
+    val command = namespace.getString("command")
+    val config = parseConfig(namespace.getString("config"))

Review Comment:
   You're right, thanks for pointing this out. I missed that when I simplified 
the `Option(...).flatMap()` config bit. I've brought that back now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to