chia7712 commented on code in PR #16176:
URL: https://github.com/apache/kafka/pull/16176#discussion_r1624574894
##########
build.gradle:
##########
@@ -47,9 +47,10 @@ plugins {
// Updating the shadow plugin version to 8.1.1 causes issue with signing and
publishing the shadowed
// artifacts - see https://github.com/johnrengelman/shadow/issues/901
id 'com.github.johnrengelman.shadow' version '8.1.0' apply false
- // the minimum required JRE of 6.14.0+ is 11
Review Comment:
Could you please add more comments to explain why we exclude JDK 8? The
previous discussion can be referenced
https://github.com/apache/kafka/pull/16172#issuecomment-2145167748
##########
build.gradle:
##########
@@ -799,7 +800,7 @@ subprojects {
skipConfigurations = [ "zinc" ]
}
- if (project.name in spotlessApplyModules) {
+ if (JavaVersion.current().isJava11Compatible() && (project.name in
spotlessApplyModules)) {
apply plugin: 'com.diffplug.spotless'
Review Comment:
another idea: Could we revers the `spotlessApplyModules` to be the "exclude
list"? For example:
```
def excludedSpotlessModules = ['core', 'client']
```
and then we remove module one by one if we apply the spotless rule. It is
more clear then before, since we can "see" which module is not applied. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
