chia7712 commented on code in PR #16176: URL: https://github.com/apache/kafka/pull/16176#discussion_r1625808103
########## README.md: ########## @@ -224,7 +224,7 @@ If needed, you can specify the Scala version with `-PscalaVersion=2.13`. There are two code quality analysis tools that we regularly run, spotbugs and checkstyle. #### Checkstyle #### -Checkstyle enforces a consistent coding style in Kafka. +Checkstyle enforces a consistent coding style in Kafka. Make sure you pass it before you submit. Review Comment: We should remind developers that `spotlessCheck` will fail if env is JDK8. `Make sure you pass it before you submit.` is a bit verbose since we have QA :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
