cmccabe commented on code in PR #16058: URL: https://github.com/apache/kafka/pull/16058#discussion_r1624993551
########## clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java: ########## @@ -1320,6 +1320,16 @@ public ListClientMetricsResourcesResult listClientMetricsResources(ListClientMet return new ListClientMetricsResourcesResult(future); } + @Override + public AddRaftVoterResult addRaftVoter(int voterId, Uuid voterDirectoryId, Set<RaftVoterEndpoint> endpoints, AddRaftVoterOptions options) { + throw new UnsupportedOperationException("Not implemented yet"); + } + + @Override + public RemoveRaftVoterResult removeRaftVoter(int voterId, Uuid voterDirectoryId, RemoveRaftVoterOptions options) { + throw new UnsupportedOperationException("Not implemented yet"); + } Review Comment: Maybe not. But Java requires them to be in MockAdminClient so that it will typecheck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org