apoorvmittal10 commented on code in PR #16054:
URL: https://github.com/apache/kafka/pull/16054#discussion_r1626207415
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/Group.java:
##########
@@ -166,4 +166,20 @@ void validateOffsetFetch(
* @return true if the state includes, false otherwise.
*/
boolean isInStates(Set<String> statesFilter, long committedOffset);
+
+ /**
+ * Returns true if the member exists.
+ *
+ * @param memberId The member id.
+ *
+ * @return A boolean indicating whether the member exists or not.
+ */
+ boolean hasMember(String memberId);
+
+ /**
+ * Returns number of members in the group.
+ *
+ * @return The number of members.
+ */
+ int numMembers();
Review Comment:
Yeah may be, but just wanted to have minimal changes in refactoring and
re-used existing i.e. ConsumerGroup already had `numMembers()` which I used for
Classic Group as well. So I ll leave this like that for now. Incase we need to
do that then will open minor refactor PR which has specific changes for
renaming it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
