jolshan commented on code in PR #16183: URL: https://github.com/apache/kafka/pull/16183#discussion_r1631735975
########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ########## @@ -205,7 +205,10 @@ public enum MetadataVersion { IBP_3_8_IV0(20, "3.8", "IV0", true), // Introduce version 1 of the GroupVersion feature (KIP-848). - IBP_4_0_IVO(21, "4.0", "IV0", false); + IBP_4_0_IVO(21, "4.0", "IV0", false), + + // Introduce version 1 of the TransactionVersion feature (KIP-890). + IBP_4_0_IV1(22, "4.0", "IV1", false); Review Comment: Sorry I misunderstood your question. I thought you were referring to the TVs being the same. I think we should keep separate from group version for now since I assume these will be released at different times. But don't feel super strongly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org