VedarthConfluent commented on code in PR #16261:
URL: https://github.com/apache/kafka/pull/16261#discussion_r1632726769
##########
docker/prepare_docker_official_image_source.py:
##########
@@ -36,14 +36,18 @@
from distutils.dir_util import copy_tree
import os
import shutil
+import re
-def remove_args_and_hardcode_values(file_path, kafka_url):
+def remove_args_and_hardcode_values(file_path, kafka_version, kafka_url):
with open(file_path, 'r') as file:
filedata = file.read()
filedata = filedata.replace("ARG kafka_url", f"ENV kafka_url {kafka_url}")
filedata = filedata.replace(
"ARG build_date", f"ENV build_date {str(date.today())}")
+ original_comment = re.compile(r"# Get kafka from
https://archive.apache.org/dist/kafka and pass the url through build arguments")
+ updated_comment = f"# Get Kafka from https://downloads.apache.org/kafka,
url passed as env var, for version {kafka_version}"
Review Comment:
I think this is mentioned in readme file so not required. This change is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
