chia7712 commented on code in PR #16253:
URL: https://github.com/apache/kafka/pull/16253#discussion_r1633398704
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/IncrementalCooperativeAssignorTest.java:
##########
@@ -1508,25 +1545,25 @@ private List<Integer>
allocations(Function<ConnectorsAndTasks, ? extends Collect
private void assertNoRevocations() {
returnedAssignments.newlyRevokedConnectors().forEach((worker,
revocations) ->
assertEquals(
- "Expected no revocations to take place during this
round, but connector revocations were issued for worker " + worker,
Collections.emptySet(),
- new HashSet<>(revocations)
+ new HashSet<>(revocations),
+ "Expected no revocations to take place during this
round, but connector revocations were issued for worker " + worker
)
);
returnedAssignments.newlyRevokedTasks().forEach((worker, revocations)
->
assertEquals(
- "Expected no revocations to take place during this
round, but task revocations were issued for worker " + worker,
Collections.emptySet(),
- new HashSet<>(revocations)
Review Comment:
@C0urante thanks for sharing. That is a good reason so please ignore my
previous comments.
> We used assertEquals here in order to see the difference between expected
and actual values if the assertion fails.
Just curious. Is it a flaky test? Comparing empty collection is not common
assert in code base. I guess there will be a PR to "cleanup" in the future.
Hence, maybe we can add more useful message to that assert for debugging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
