chia7712 commented on code in PR #16253:
URL: https://github.com/apache/kafka/pull/16253#discussion_r1634334649


##########
build.gradle:
##########
@@ -573,7 +573,7 @@ subprojects {
         useJUnitPlatform {
           includeTags "integration"
           includeTags "org.apache.kafka.test.IntegrationTest"
-         // Both engines are needed to run JUnit 4 tests alongside JUnit 5 
tests.
+          // Both engines are needed to run JUnit 4 tests alongside JUnit 5 
tests.

Review Comment:
   Please revert those unrelated change



##########
build.gradle:
##########
@@ -616,7 +616,7 @@ subprojects {
         useJUnitPlatform {
           excludeTags "integration"
           excludeTags "org.apache.kafka.test.IntegrationTest"
-         // Both engines are needed to run JUnit 4 tests alongside JUnit 5 
tests.
+          // Both engines are needed to run JUnit 4 tests alongside JUnit 5 
tests.

Review Comment:
   Please revert those unrelated change



##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java:
##########
@@ -1889,4 +1888,4 @@ private void assertTaskMetricValue(String name, String 
expected) {
         String measured = metrics.currentMetricValueAsString(taskGroup, name);
         assertEquals(expected, measured);
     }
-}

Review Comment:
   Please revert this unrelated change



##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/StateTrackerTest.java:
##########
@@ -100,4 +100,4 @@ public void calculateDurations() {
 
     }
 
-}
\ No newline at end of file
+}

Review Comment:
   Please revert this unrelated change



##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java:
##########
@@ -362,24 +362,16 @@ private void verifyNormalConnector() throws 
InterruptedException {
     private void assertRequestTimesOut(String requestDescription, 
ThrowingRunnable request, String expectedTimeoutMessage) {

Review Comment:
   `ThrowingRunnable` should be replaced by `Executable`



##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResourceTest.java:
##########
@@ -162,4 +162,4 @@ public void testSetLevelClusterScope() {
         verify(herder).setClusterLoggerLevel(logger, level);
     }
 
-}

Review Comment:
   Please revert this unrelated change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to