C0urante commented on code in PR #16288:
URL: https://github.com/apache/kafka/pull/16288#discussion_r1635549634
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java:
##########
@@ -169,7 +164,6 @@ public void
testFailToStartWhenInternalTopicsAreNotCompacted() throws Interrupte
// Start the brokers but not Connect
log.info("Starting {} Kafka brokers, but no Connect workers yet",
numBrokers);
connect.start();
Review Comment:
I'm happy to rework
`testFailToCreateInternalTopicsWithMoreReplicasThanBrokers`, but just in case
someone downstream is using `start` in a way that relies on existing behavior,
I'd also like to keep in the non-blocking method, even if we don't use it in
any of our tests. I know we're not under any obligation to but it's such a
small change that the negligible maintenance burden seems worth the tradeoff.
Does that work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
