C0urante commented on code in PR #16288:
URL: https://github.com/apache/kafka/pull/16288#discussion_r1636615220
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java:
##########
@@ -169,7 +164,6 @@ public void
testFailToStartWhenInternalTopicsAreNotCompacted() throws Interrupte
// Start the brokers but not Connect
log.info("Starting {} Kafka brokers, but no Connect workers yet",
numBrokers);
connect.start();
Review Comment:
That's a great point. I've removed the overloaded variant and tweaked the
only remaining integration test that uses it. That test itself is actually
subtly broken since it doesn't (and never did) synchronously wait for worker
startup before checking that internal topics don't exist, but since this PR
doesn't introduce a regression I've thrown a TODO into the codebase and left
everything else for a follow-up.
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/SourceConnectorsIntegrationTest.java:
##########
@@ -160,8 +156,6 @@ public void testSwitchingToTopicCreationEnabled() throws
InterruptedException {
connect.assertions().assertTopicSettings(BAR_TOPIC,
DEFAULT_REPLICATION_FACTOR,
DEFAULT_PARTITIONS, "Topic " + BAR_TOPIC + " does not have the
expected settings");
- connect.assertions().assertAtLeastNumWorkersAreUp(NUM_WORKERS,
"Initial group of workers did not start in time.");
-
Map<String, String> barProps = defaultSourceConnectorProps(BAR_TOPIC);
Review Comment:
Great catch, fixed!
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java:
##########
@@ -218,9 +218,6 @@ public void testRestartFailedTask() throws Exception {
props.put(TASKS_MAX_CONFIG, Objects.toString(numTasks));
props.put(CONNECTOR_CLIENT_PRODUCER_OVERRIDES_PREFIX +
BOOTSTRAP_SERVERS_CONFIG, "nobrokerrunningatthisaddress");
Review Comment:
👍, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
