junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1637226783
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -228,7 +231,7 @@ public enum MetadataVersion {
* <strong>Think carefully before you update this value. ONCE A METADATA
VERSION IS PRODUCTION,
* IT CANNOT BE CHANGED.</strong>
*/
- public static final MetadataVersion LATEST_PRODUCTION = IBP_3_7_IV4;
+ public static final MetadataVersion LATEST_PRODUCTION = IBP_3_8_IV1;
Review Comment:
@jolshan: What's the benefit of reusing 3.8-IV0 for ListOffset instead of
creating a new 3.8-IV1? To me, creating 3.8-IV1 makes it a bit easier to
understand the change history. It leaves an IV unused, but that doesn't seem a
big concern.
##########
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java:
##########
@@ -21,10 +21,10 @@
public enum TestFeatureVersion implements FeatureVersion {
- // TEST_1 released right before MV 3.7-IVO was released, and it has no
dependencies
+ // TEST_1 released right before MV 3.7-IV0 was released, and it has no
dependencies
TEST_1(1, MetadataVersion.IBP_3_7_IV0, Collections.emptyMap()),
- // TEST_2 released right before MV 3.8-IVO was released, and it depends on
this metadata version
- TEST_2(2, MetadataVersion.IBP_3_8_IV0,
Collections.singletonMap(MetadataVersion.FEATURE_NAME,
MetadataVersion.IBP_3_8_IV0.featureLevel()));
+ // TEST_2 released right before MV 4.0-IV0 was released, and it depends on
this metadata version
+ TEST_2(2, MetadataVersion.IBP_4_0_IV0,
Collections.singletonMap(MetadataVersion.FEATURE_NAME,
MetadataVersion.IBP_4_0_IV0.featureLevel()));
Review Comment:
@jolshan left a comment earlier.
https://github.com/apache/kafka/pull/15673#discussion_r1630117332
Since she plans to create a new feature TEST_3 for unstable version. We
probably can keep this at 3_8_IV1 since it's a stable version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
