junrao commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1637247133


##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -228,7 +231,7 @@ public enum MetadataVersion {
      * <strong>Think carefully before you update this value. ONCE A METADATA 
VERSION IS PRODUCTION,
      * IT CANNOT BE CHANGED.</strong>
      */
-    public static final MetadataVersion LATEST_PRODUCTION = IBP_3_7_IV4;
+    public static final MetadataVersion LATEST_PRODUCTION = IBP_3_8_IV1;

Review Comment:
   ELR was originally associated with IBP_3_7_IV3. When it's moved IBP_3_8_IV0, 
we left IBP_3_7_IV3 unused since IBP_3_7_IV4 has already been implemented. We 
didn't reuse IBP_3_7_IV3. Here, there is no 3.8 IV after IBP_3_8_IV0. So, we 
could reuse  IBP_3_8_IV0 for ListOffset. However, it seems that a simpler and 
more consistent policy is to never reuse an IV?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to