chia7712 commented on code in PR #16324:
URL: https://github.com/apache/kafka/pull/16324#discussion_r1639091686
##########
gradle/dependencies.gradle:
##########
@@ -237,14 +237,14 @@ libs += [
pcollections: "org.pcollections:pcollections:$versions.pcollections",
opentelemetryProto:
"io.opentelemetry.proto:opentelemetry-proto:$versions.opentelemetryProto",
reflections: "org.reflections:reflections:$versions.reflections",
+ slf4jReload4j: "org.slf4j:slf4j-reload4j:$versions.slf4j",
Review Comment:
Could you please move it down to around `slf4jApi`?
##########
bin/kafka-run-class.sh:
##########
@@ -243,6 +243,14 @@ fi
(( WINDOWS_OS_FORMAT )) && LOG_DIR=$(cygpath --path --mixed "${LOG_DIR}")
KAFKA_LOG4J_CMD_OPTS="-Dkafka.logs.dir=$LOG_DIR $KAFKA_LOG4J_OPTS"
+# slf4j provider settings
+if [ -z "$SLF4J_PROVIDER" ]; then
+ SLF4J_PROVIDER="org.slf4j.reload4j.Reload4jServiceProvider"
+fi
+
+# Add the slf4j provider to KAFKA_OPTS
+KAFKA_OPTS="$KAFKA_OPTS -Dslf4j.provider=$SLF4J_PROVIDER"
Review Comment:
Could we merge this new property into either `KAFKA_LOG4J_OPTS` or
`KAFKA_LOG4J_CMD_OPTS`? Also, please add it to `kafka-run-class.bat` too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
