chia7712 commented on code in PR #16324:
URL: https://github.com/apache/kafka/pull/16324#discussion_r1644499138
##########
build.gradle:
##########
@@ -928,14 +928,15 @@ project(':server') {
implementation libs.jacksonDatabind
implementation libs.slf4jApi
+ implementation libs.slf4jReload4j
Review Comment:
> it also seems this could break users that provide their own slf4j backend,
for example someone using slf4j-simple-1.5.5.jar. After tis change they need to
switch to slf4j-simple-2.0.13.jar.
That is a good point, and it seems to me the true issue is "should we
guarantee the compatibility of dependency chain in updating kafka dependencies?"
If the answer is yes, it implies that we need KIP for each dependency update
because it is always possible to break user-provided dependencies.
Or slf4j is a special case that we do care? If so, a workaround is that we
add dependency of all slf4j backend. If users are using kafka as dependency, it
makes users' dependency management tool to use the "newer" backend implicitly.
If users want to run kafka with different provider, they can define system
variable instead of offering provider jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
