lianetm commented on code in PR #16312:
URL: https://github.com/apache/kafka/pull/16312#discussion_r1645039449
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -141,23 +136,41 @@ private MembershipManagerImpl
createMembershipManagerJoiningGroup(String groupIn
}
private MembershipManagerImpl createMembershipManager(String
groupInstanceId) {
- return spy(new MembershipManagerImpl(
+ return new MembershipManagerImpl(
GROUP_ID, Optional.ofNullable(groupInstanceId), REBALANCE_TIMEOUT,
Optional.empty(),
subscriptionState, commitRequestManager, metadata, logContext,
Optional.empty(),
- backgroundEventHandler, time, rebalanceMetricsManager));
+ backgroundEventHandler, time, rebalanceMetricsManager);
}
private MembershipManagerImpl createMembershipManagerJoiningGroup(String
groupInstanceId,
String
serverAssignor) {
- MembershipManagerImpl manager = spy(new MembershipManagerImpl(
+ MembershipManagerImpl manager = new MembershipManagerImpl(
GROUP_ID, Optional.ofNullable(groupInstanceId),
REBALANCE_TIMEOUT,
Optional.ofNullable(serverAssignor), subscriptionState,
commitRequestManager,
metadata, logContext, Optional.empty(),
backgroundEventHandler, time,
- rebalanceMetricsManager));
+ rebalanceMetricsManager);
manager.transitionToJoining();
return manager;
}
+ private void createCommitRequestManager(boolean autoCommit) {
+ ConsumerConfig config = mock(ConsumerConfig.class);
+ if (autoCommit) {
+
when(config.getBoolean(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG)).thenReturn(true);
+ }
+
+ commitRequestManager = new CommitRequestManager(
Review Comment:
I would aim for not having an actual commitRequestManager here, a mock
should do, but I may be missing something. Check my other comments to get rid
of the `createCommitRequestManager` (and maybe we can end up removing this?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
