muralibasani commented on code in PR #16325:
URL: https://github.com/apache/kafka/pull/16325#discussion_r1665647113
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -503,24 +537,29 @@ object StorageTool extends Logging {
}
def formatCommand(
- stream: PrintStream,
- directories: Seq[String],
- metaProperties: MetaProperties,
- metadataVersion: MetadataVersion,
- ignoreFormatted: Boolean
- ): Int = {
+ stream: PrintStream,
+ directories: Seq[String],
+ metaProperties: MetaProperties,
+ metadataVersion: MetadataVersion,
+ ignoreFormatted: Boolean,
+ advertisedListenerEndpoints:
scala.collection.Seq[kafka.cluster.EndPoint],
+ controllersQuorumVoters: String
+ ): Int = {
val bootstrapMetadata = buildBootstrapMetadata(metadataVersion, None,
"format command")
- formatCommand(stream, directories, metaProperties, bootstrapMetadata,
metadataVersion, ignoreFormatted)
+ formatCommand(stream, directories, metaProperties, bootstrapMetadata,
metadataVersion, ignoreFormatted,
+ advertisedListenerEndpoints, controllersQuorumVoters)
}
def formatCommand(
- stream: PrintStream,
- directories: Seq[String],
- metaProperties: MetaProperties,
- bootstrapMetadata: BootstrapMetadata,
- metadataVersion: MetadataVersion,
- ignoreFormatted: Boolean
- ): Int = {
+ stream: PrintStream,
+ directories: Seq[String],
+ metaProperties: MetaProperties,
+ bootstrapMetadata: BootstrapMetadata,
+ metadataVersion: MetadataVersion,
+ ignoreFormatted: Boolean,
+ advertisedListenerEndpoints:
scala.collection.Seq[kafka.cluster.EndPoint],
+ controllersQuorumVoters: String
Review Comment:
Tried considering but directoryId is derived only in format method. So
updated format method with only listeners param.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
