muralibasani commented on code in PR #16325:
URL: https://github.com/apache/kafka/pull/16325#discussion_r1672833818
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -112,20 +112,21 @@ object StorageTool extends Logging {
setNodeId(config.nodeId).
build()
val standaloneMode = namespace.getBoolean("standalone")
- var advertisedListenerEndpoints: collection.Seq[kafka.cluster.EndPoint] =
List()
val controllersQuorumVoters =
namespace.getString("controller_quorum_voters")
if(standaloneMode && controllersQuorumVoters != null) {
throw new TerseFailure("Both --standalone and --controller-quorum-voters
were set. Only one of the two flags can be set.")
}
+ var listeners: util.Map[ListenerName, InetSocketAddress] = new
util.HashMap()
if (standaloneMode) {
- advertisedListenerEndpoints = config.effectiveAdvertisedBrokerListeners
+ listeners = createStandaloneVoterMap(config)
} else if(controllersQuorumVoters != null) {
if (!validateControllerQuorumVoters(controllersQuorumVoters)) {
throw new TerseFailure("Expected schema for --controller-quorum-voters
is <replica-id>[-<replica-directory-id>]@<host>:<port>")
}
- advertisedListenerEndpoints =
config.effectiveAdvertisedControllerListeners
+ val controllerQuorumVoterMap: util.Map[Integer, InetSocketAddress] =
parseVoterConnections(Collections.singletonList(controllersQuorumVoters))
+ listeners = parseControllerQuorumVotersMap(controllerQuorumVoterMap,
metaProperties, config)
Review Comment:
This means we would have to update
https://github.com/apache/kafka/blob/25d775b742406477a0ff678b9990ed149d2157cc/raft/src/main/java/org/apache/kafka/raft/QuorumConfig.java#L178
to return Uuid too ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
