C0urante commented on code in PR #16525:
URL: https://github.com/apache/kafka/pull/16525#discussion_r1669116891


##########
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java:
##########
@@ -354,8 +355,10 @@ private <T extends SourceConnector> void 
awaitTaskConfigurations(MirrorMaker mm,
                         .map(TaskInfo::config)
                         .allMatch(predicate);
             } catch (Exception ex) {

Review Comment:
   True, I wanted to play it safe but upon reflection I also can't think of a 
single case where we'd want to handle anything except an ExecutionException 
that wraps a RebalanceNeededException. I've pushed an update to address this; 
LMKWYT



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to