masonyc commented on code in PR #16563:
URL: https://github.com/apache/kafka/pull/16563#discussion_r1673180531
##########
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##########
@@ -1233,7 +1238,7 @@ static void verifyLeaderChangeMessage(
LeaderChangeMessage leaderChangeMessage =
ControlRecordUtils.deserializeLeaderChangeMessage(recordValue);
assertEquals(leaderId, leaderChangeMessage.leaderId());
assertEquals(voters.stream().map(voterId -> new
Voter().setVoterId(voterId)).collect(Collectors.toList()),
- leaderChangeMessage.voters());
+
leaderChangeMessage.voters().stream().sorted(Comparator.comparingInt(Voter::voterId)).collect(Collectors.toList()));
Review Comment:
thanks for the feedback, we still need to collect to List, otherwise the
assertion will fail. Updated format in latest commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
