masonyc commented on PR #16563: URL: https://github.com/apache/kafka/pull/16563#issuecomment-2221709715
> Thanks for the changes @masonyc. > > Can you confirm that some of these tests fail if you remove `"default": "-1",` from these two schemas? > > 1. https://github.com/apache/kafka/blob/trunk/clients/src/main/resources/common/message/VoteRequest.json#L27 > 2. https://github.com/apache/kafka/blob/trunk/clients/src/main/resources/common/message/BeginQuorumEpochRequest.json#L27 > > While verifying the above, can you also confirm that the test failures provide enough information to reproduce the failure. I am concerned that since the replica ids are random the test failures won't provide enough information to know which replica id value cause the failure. > > Let's make similar changes to `KafkaRaftClientSnapshotTest`. Hi @jsancio , thanks for the review. Confirmed that I can see test failures when removing the -1 flag in both schemas. I have added the Leader Id passed from test case and Leader Id from Raft Response into the assertion message block so it can be used to reproduce the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
