mjsax commented on code in PR #16373:
URL: https://github.com/apache/kafka/pull/16373#discussion_r1685169766
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -485,6 +485,18 @@ public void resetTimer() {
this.heartbeatTimer.reset(heartbeatIntervalMs);
}
+ @Override
+ public String toStringBase() {
+ return super.toStringBase() +
+ ", remainingMs=" + heartbeatTimer.remainingMs() +
+ ", heartbeatIntervalMs=" + heartbeatIntervalMs;
+ }
+
+ // Visible for testing
+ Timer heartbeatTimer() {
Review Comment:
Cf my other comment -- I think we don't need to add this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
