[
https://issues.apache.org/jira/browse/KAFKA-17173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867572#comment-17867572
]
Eric Chang commented on KAFKA-17173:
------------------------------------
I wanna give it a try!
> Move all quota getters from `KafkaConfig` to `QuotaConfigs`
> -----------------------------------------------------------
>
> Key: KAFKA-17173
> URL: https://issues.apache.org/jira/browse/KAFKA-17173
> Project: Kafka
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Minor
>
> {code:scala}
> /** ********* Quota Configuration **************/
> val numQuotaSamples = getInt(QuotaConfigs.NUM_QUOTA_SAMPLES_CONFIG)
> val quotaWindowSizeSeconds =
> getInt(QuotaConfigs.QUOTA_WINDOW_SIZE_SECONDS_CONFIG)
> val numReplicationQuotaSamples =
> getInt(QuotaConfigs.NUM_REPLICATION_QUOTA_SAMPLES_CONFIG)
> val replicationQuotaWindowSizeSeconds =
> getInt(QuotaConfigs.REPLICATION_QUOTA_WINDOW_SIZE_SECONDS_CONFIG)
> val numAlterLogDirsReplicationQuotaSamples =
> getInt(QuotaConfigs.NUM_ALTER_LOG_DIRS_REPLICATION_QUOTA_SAMPLES_CONFIG)
> val alterLogDirsReplicationQuotaWindowSizeSeconds =
> getInt(QuotaConfigs.ALTER_LOG_DIRS_REPLICATION_QUOTA_WINDOW_SIZE_SECONDS_CONFIG)
> val numControllerQuotaSamples =
> getInt(QuotaConfigs.NUM_CONTROLLER_QUOTA_SAMPLES_CONFIG)
> val controllerQuotaWindowSizeSeconds =
> getInt(QuotaConfigs.CONTROLLER_QUOTA_WINDOW_SIZE_SECONDS_CONFIG)
> {code}
> Noted that"
> 1. `QuotaConfigs` -> `QuotaConfig`
> 2. those variables are not dynamic, so we can create local variety for them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
