[ 
https://issues.apache.org/jira/browse/KAFKA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867659#comment-17867659
 ] 

Chris Egerton commented on KAFKA-17174:
---------------------------------------

I'm not sure this is the right direction to go in. [~javakillah] I'd like to 
discuss the tradeoffs with [~chia7712] on 
[https://github.com/apache/kafka/pull/16599] (where this was originally 
proposed) before anyone starts working on implementing this.

> Migrate OffsetsApiIntegrationTest to use ClusterTestExtensions
> --------------------------------------------------------------
>
>                 Key: KAFKA-17174
>                 URL: https://issues.apache.org/jira/browse/KAFKA-17174
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Minor
>
> Connect module has its `EmbeddedKafkaCluster`, so another alternative is to 
> re-implement it by `ClusterInstance`. However, both of them are a kind of 
> "embedded service" interface. Personally, I prefer to unify the interface for 
> all modules in testing. We can move any useful helpers from 
> `EmbeddedKafkaCluster` to `ClusterInstance` in order to make other modules 
> get benefits too.
> `OffsetsApiIntegrationTest` is a lightweight user of  `EmbeddedKafkaCluster`, 
> so it can be a good entrypoint to introduce `ClusterInstance` to connect 
> module



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to