[
https://issues.apache.org/jira/browse/KAFKA-17174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868132#comment-17868132
]
Chris Egerton commented on KAFKA-17174:
---------------------------------------
I've left my thoughts on the PR I linked above, but wanted to copy them here
too. Basically, I don't think we should fragment Connect's integration tests
and use {{EmbeddedKafkaCluster}} in some but {{ClusterInstance}} in others
(unless we're in the midst of a short migration period where the work is broken
up into several smaller PRs, some of which have been merged and some of which
have not). So while I'm not opposed to this proposal, I don't think we should
move forward with it until we have a plan for migrating all of Connect's tests
instead of just some of them.
> Migrate OffsetsApiIntegrationTest to use ClusterTestExtensions
> --------------------------------------------------------------
>
> Key: KAFKA-17174
> URL: https://issues.apache.org/jira/browse/KAFKA-17174
> Project: Kafka
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Minor
>
> Connect module has its `EmbeddedKafkaCluster`, so another alternative is to
> re-implement it by `ClusterInstance`. However, both of them are a kind of
> "embedded service" interface. Personally, I prefer to unify the interface for
> all modules in testing. We can move any useful helpers from
> `EmbeddedKafkaCluster` to `ClusterInstance` in order to make other modules
> get benefits too.
> `OffsetsApiIntegrationTest` is a lightweight user of `EmbeddedKafkaCluster`,
> so it can be a good entrypoint to introduce `ClusterInstance` to connect
> module
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
