showuon commented on code in PR #16653:
URL: https://github.com/apache/kafka/pull/16653#discussion_r1687894187
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -470,7 +479,8 @@ public void onLeadershipChange(Set<Partition>
partitionsBecomeLeader,
* @param errorHandler callback to handle any errors while stopping the
partitions.
*/
public void stopPartitions(Set<StopPartition> stopPartitions,
- BiConsumer<TopicPartition, Throwable>
errorHandler) {
+ BiConsumer<TopicPartition, Throwable>
errorHandler,
+ String remoteLogDisablePolicy) {
Review Comment:
Sorry, I didn't get your question here. I added the 3rd parameter here
because most of the logic is similar, just a few differences. Do you have any
suggestion here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
