showuon commented on PR #16653: URL: https://github.com/apache/kafka/pull/16653#issuecomment-2247062186
> With "retain" disablement policy, we are not calling the RLMM#onStopPartitions(Set partitions) and cancelling the expiry RLM task once all the remote log segments are deleted asynchronously. Do we plan to leave those resources open? This is a good question. With "retain", we can't stop RLMM because the metadata will still be updated with log deletion. But what should we do after all remote log segments are deleted, I don't have good solution for now. I think we can add a checker here that if "retain" is set and no more remote log segments, we cancel the task, and stop RLMM. But I don't know if there's any side effect. https://github.com/apache/kafka/blob/7efb58f3211cdc3bd0524a79f9b5ce4ef74a77b4/core/src/main/java/kafka/log/remote/RemoteLogManager.java#L1178 I've created [KAFKA-17191](https://issues.apache.org/jira/browse/KAFKA-17191) for this improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
