kamalcph commented on code in PR #16653:
URL: https://github.com/apache/kafka/pull/16653#discussion_r1698287450
##########
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##########
@@ -1830,12 +1872,14 @@ void doHandleFollowerPartition(TopicIdPartition
topicPartition) {
expirationRLMTaskWithFuture.cancel();
}
- followerRLMTasks.computeIfAbsent(topicPartition, topicIdPartition -> {
- RLMFollowerTask task = new RLMFollowerTask(topicIdPartition);
- LOGGER.info("Created a new follower task: {} and getting
scheduled", task);
- ScheduledFuture<?> future =
followerThreadPool.scheduleWithFixedDelay(task, 0, delayInMs,
TimeUnit.MILLISECONDS);
- return new RLMTaskWithFuture(task, future);
- });
+ if (!remoteCopyDisabled) {
Review Comment:
I think we may have to leave the followerRLMTask to be running in the
background. Assume that the follower gets reassigned from one broker to another
when remoteCopy is disabled. Will the newly reassigned follower able to serve
the remote data when consumer is configured to read from follower using the
`preferredReadReplica` feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
