mjsax commented on code in PR #16745:
URL: https://github.com/apache/kafka/pull/16745#discussion_r1699432799
##########
streams/src/test/java/org/apache/kafka/streams/integration/ProcessingExceptionHandlerIntegrationTest.java:
##########
@@ -222,9 +221,9 @@ public void
shouldStopOnFailedProcessorWhenProcessingExceptionOccursInContinuePr
}
@Test
- public void
shouldStopProcessingWhenFatalUserExceptionInFailProcessingExceptionHandler() {
+ public void
shouldStopProcessingWhenProcessingExceptionHandlerReturnsNull() {
Review Comment:
Re-purposed this test case for NULL case.
It seem redundant to test "throw exception" twice as originally in the code
(one for FAIL and once for CONTINUE), because if we throw, there is no response
we return at all...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
