mjsax commented on code in PR #16745:
URL: https://github.com/apache/kafka/pull/16745#discussion_r1699436189
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##########
@@ -2723,56 +2737,106 @@ public void
shouldPunctuateNotHandleTaskMigratedExceptionAndThrowItAsIs() {
}
@Test
- public void
shouldPunctuateNotThrowStreamsExceptionWhenProcessingExceptionHandlerRepliesWithContinue()
{
+ public void
punctuateShouldNotThrowStreamsExceptionWhenProcessingExceptionHandlerRepliesWithContinue()
{
when(stateManager.taskId()).thenReturn(taskId);
when(stateManager.taskType()).thenReturn(TaskType.ACTIVE);
- task = createStatelessTask(createConfig(AT_LEAST_ONCE, "100",
- LogAndFailExceptionHandler.class.getName(),
LogAndContinueProcessingExceptionHandler.class.getName()));
+ task = createStatelessTask(createConfig(
+ AT_LEAST_ONCE,
+ "100",
+ LogAndFailExceptionHandler.class.getName(),
+ LogAndContinueProcessingExceptionHandler.class.getName()
+ ));
- assertDoesNotThrow(() ->
Review Comment:
No need for this... if it would throw, the test fails anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
