philipnee commented on code in PR #16685:
URL: https://github.com/apache/kafka/pull/16685#discussion_r1700483329
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -320,10 +322,11 @@ private void process(final
ConsumerRebalanceListenerCallbackNeededEvent event) {
ApiVersions apiVersions = new ApiVersions();
final BlockingQueue<ApplicationEvent> applicationEventQueue = new
LinkedBlockingQueue<>();
- final BackgroundEventHandler backgroundEventHandler = new
BackgroundEventHandler(backgroundEventQueue);
+ final BackgroundEventHandler backgroundEventHandler = new
BackgroundEventHandler(backgroundEventQueue, kafkaConsumerMetrics);
// This FetchBuffer is shared between the application and network
threads.
this.fetchBuffer = new FetchBuffer(logContext);
+ final NetworkThreadMetricsManager networkThreadMetricsManager =
new NetworkThreadMetricsManager(metrics);
Review Comment:
construct it in the ApplicationEventHandler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
