philipnee commented on code in PR #16685:
URL: https://github.com/apache/kafka/pull/16685#discussion_r1700493932
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -67,14 +69,18 @@ public class ConsumerNetworkThread extends KafkaThread
implements Closeable {
private final IdempotentCloser closer = new IdempotentCloser();
private volatile Duration closeTimeout =
Duration.ofMillis(DEFAULT_CLOSE_TIMEOUT_MS);
private volatile long cachedMaximumTimeToWait = MAX_POLL_TIMEOUT_MS;
+ // Visible for testing
+ final NetworkThreadMetricsManager metricsManager;
Review Comment:
i couldn't find any usage of this metrics manager. If this needs to be
accessed in test maybe write a getter instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
