philipnee commented on code in PR #16686:
URL: https://github.com/apache/kafka/pull/16686#discussion_r1700569374
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##########
@@ -1227,6 +1227,7 @@ public void close(Duration timeout) {
private void close(Duration timeout, boolean swallowException) {
log.trace("Closing the Kafka consumer");
+ boolean wasInterrupted = Thread.interrupted();
Review Comment:
i wonder if we could just do if(Thread.interrupted()) firstException = new
InterruptException())
I think if the thread was interrupted and other exceptions were thrown, we
still want to throw interruptException? If the thread was not interrupted, then
we may throw other exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
