kirktrue commented on code in PR #16686: URL: https://github.com/apache/kafka/pull/16686#discussion_r1700594272
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ########## @@ -1227,6 +1227,7 @@ public void close(Duration timeout) { private void close(Duration timeout, boolean swallowException) { log.trace("Closing the Kafka consumer"); + boolean wasInterrupted = Thread.interrupted(); Review Comment: I think we need to handle the case where the thread is interrupted both _before_ and _during_ the call to `close()`. But you're right, looking back at the Jira, it clearly states the _during_ case, which I somehow missed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org