mjsax commented on code in PR #16745:
URL: https://github.com/apache/kafka/pull/16745#discussion_r1702256466
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java:
##########
@@ -1800,7 +1900,10 @@ public ProductionExceptionHandlerResponse handle(final
ErrorHandlerContext conte
final
ProducerRecord<byte[], byte[]> record,
final Exception
exception) {
assertInputs(context, exception);
- return response;
+ if (response == null) {
Review Comment:
`null` is on purpose. It's how we setup the code (it's not something the
handler return).
In the end `response` is "what should the handler return in this test run",
and I miss use it to say "handler should throw an exception". I could also add
a new boolean flag `shouldThrowException` instead to not miss use `response`
for this case.
Will update the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
