jsancio commented on code in PR #16735:
URL: https://github.com/apache/kafka/pull/16735#discussion_r1704040902
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -543,6 +555,15 @@ public void initialize(
quorumConfig.requestTimeoutMs(),
logContext
);
+
+ // Specialized remove voter handler
+ this.updateVoterHandler = new UpdateVoterHandler(
+ nodeId,
+ partitionState,
+ channel.listenerName(),
+ time,
+ quorumConfig.requestTimeoutMs()
Review Comment:
Not sure I understand the question. In general inputs to a type or method
should be limited to what they require. This avoid passing a configuration
object with many methods where only one is used or required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
