jsancio commented on code in PR #16235:
URL: https://github.com/apache/kafka/pull/16235#discussion_r1706197212
##########
clients/src/main/resources/common/message/FetchRequest.json:
##########
@@ -100,7 +102,9 @@
{ "name": "LogStartOffset", "type": "int64", "versions": "5+",
"default": "-1", "ignorable": true,
"about": "The earliest available offset of the follower replica.
The field is only used when the request is sent by the follower."},
{ "name": "PartitionMaxBytes", "type": "int32", "versions": "0+",
- "about": "The maximum bytes to fetch from this partition. See
KIP-74 for cases where this limit may not be honored." }
+ "about": "The maximum bytes to fetch from this partition. See
KIP-74 for cases where this limit may not be honored." },
+ { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "17+",
"taggedVersions": "17+", "tag": 0,
Review Comment:
@chia7712 this is a tagged field so it should show as an unknown tagged
field on older client. KRaft only support Fetch with version 12+ and tag fields
(flexible version) was added in version 12. Are you not seeing that? We should
be exercising this in `KafkaRaftClientTest` and `RaftClientTestContext`. This
is how we test different version in the KRaft tests using
`RaftClientTestContxt.fetchRpcVersion`:
```java
private short fetchRpcVersion() {
if (kip853Rpc) {
return 17;
} else {
return 16;
}
}
```
What error are you getting @chia7712 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
