jsancio commented on code in PR #16235:
URL: https://github.com/apache/kafka/pull/16235#discussion_r1706206849
##########
clients/src/main/resources/common/message/FetchRequest.json:
##########
@@ -100,7 +102,9 @@
{ "name": "LogStartOffset", "type": "int64", "versions": "5+",
"default": "-1", "ignorable": true,
"about": "The earliest available offset of the follower replica.
The field is only used when the request is sent by the follower."},
{ "name": "PartitionMaxBytes", "type": "int32", "versions": "0+",
- "about": "The maximum bytes to fetch from this partition. See
KIP-74 for cases where this limit may not be honored." }
+ "about": "The maximum bytes to fetch from this partition. See
KIP-74 for cases where this limit may not be honored." },
+ { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "17+",
"taggedVersions": "17+", "tag": 0,
Review Comment:
I see the issue in the generator code:
```java
if (_version >= 17) {
if (!this.replicaDirectoryId.equals(Uuid.ZERO_UUID)) {
_numTaggedFields++;
}
} else {
if (!this.replicaDirectoryId.equals(Uuid.ZERO_UUID)) {
throw new UnsupportedVersionException("Attempted to
write a non-default replicaDirectoryId at version " + _version);
}
}
```
We need to mark the field as ignorable. Same for the `FetchSnapshotRequest`.
Are you going to work on the PR @chia7712 ? If so, I can review it when it
is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
