frankvicky commented on code in PR #16833:
URL: https://github.com/apache/kafka/pull/16833#discussion_r1711704438
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##########
@@ -1003,11 +1003,13 @@ private void onFailure(final long currentTimeMs,
// Re-discover the coordinator and retry
coordinatorRequestManager.markCoordinatorUnknown("error
response " + responseError.name(), currentTimeMs);
future.completeExceptionally(responseError.exception());
+ } else if (responseError.exception() instanceof
RetriableException) {
+ // If fail with a retriable KafkaException, then retry
+ future.completeExceptionally(responseError.exception());
Review Comment:
Hi @lianetm ,
Thank you very much for the detailed explanation; it's very enlightening and
I learn the context from it. 😺
I agree that these checks are fair. I will extend the `testRetriable` and
`testNonRetriable` tests, and after that, I will modify the PR to follow the
updated logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
