chia7712 commented on PR #16833: URL: https://github.com/apache/kafka/pull/16833#issuecomment-2284310671
> The failAndRemoveExpiredFetchRequests method at L1198 clears expired fetch requests from unsentOffsetFetches. However, the partitionedBySendability collection at L1194 is created using unsentOffsetFetches, and its result does not change due to the check performed at L1198. So even if an expired fetch request is removed in failAndRemoveExpiredFetchRequests, as long as the fetch request was canSendRequest when partitionedBySendability was created, it will still be added to unsentRequests and eventually included in the PollResult . This seems not reasonable, as expired fetch requests should not be sent again. yep, that is totally a bug I think. Could you please fix it in this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
