junrao commented on code in PR #16786:
URL: https://github.com/apache/kafka/pull/16786#discussion_r1714166779
##########
group-coordinator/src/main/resources/common/message/ShareGroupPartitionMetadataValue.json:
##########
@@ -20,25 +20,21 @@
"validVersions": "0",
"flexibleVersions": "0+",
"fields": [
- { "name": "InitializedTopics", "versions": "0+", "type":
"[]TopicPartitionsInfo",
- "about": "The topics with initialized share-group state." },
- { "name": "DeletingTopics", "versions": "0+", "type": "[]TopicInfo",
- "about": "The topics whose share-group state is being deleted." }
- ],
- "commonStructs": [
- { "name": "TopicPartitionsInfo", "versions": "0+", "fields": [
- { "name": "TopicId", "type": "uuid", "versions": "0+",
- "about": "The topic identifier." },
- { "name": "TopicName", "type": "string", "versions": "0+",
+ { "name": "Topics", "versions": "0+", "type": "[]TopicMetadata",
Review Comment:
This matches ConsumerGroupPartitionMetadataValue for tracking the last know
topic/partition metadata. However, `InitializedTopics` and `DeletingTopics`
were designed for keeping track of the pending state needed for the Persister.
How is the functionality achieved now?
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/Assignment.java:
##########
@@ -85,4 +86,20 @@ public static Assignment fromRecord(
topicPartitions -> new
HashSet<>(topicPartitions.partitions())))
);
}
+
+ /**
+ * Creates a {{@link Assignment}} from a {{@link
ConsumerGroupTargetAssignmentMemberValue}}.
Review Comment:
Incorrect reference `ConsumerGroupTargetAssignmentMemberValue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
