AndrewJSchofield commented on code in PR #16786:
URL: https://github.com/apache/kafka/pull/16786#discussion_r1714833667
##########
group-coordinator/src/main/resources/common/message/ShareGroupPartitionMetadataValue.json:
##########
@@ -20,25 +20,21 @@
"validVersions": "0",
"flexibleVersions": "0+",
"fields": [
- { "name": "InitializedTopics", "versions": "0+", "type":
"[]TopicPartitionsInfo",
- "about": "The topics with initialized share-group state." },
- { "name": "DeletingTopics", "versions": "0+", "type": "[]TopicInfo",
- "about": "The topics whose share-group state is being deleted." }
- ],
- "commonStructs": [
- { "name": "TopicPartitionsInfo", "versions": "0+", "fields": [
- { "name": "TopicId", "type": "uuid", "versions": "0+",
- "about": "The topic identifier." },
- { "name": "TopicName", "type": "string", "versions": "0+",
+ { "name": "Topics", "versions": "0+", "type": "[]TopicMetadata",
Review Comment:
That's because the previous `ShareGroupPartitionMetadata` in the KIP has
become the new `ShareGroupStatePartitionMetadata`. This is because the pattern
is that every record in KIP-848 which has the name `ConsumerGroupXXXX` has an
equivalent `ShareGroupXXXX`, and `ConsumerGroupPartitionMetadata` needed an
equivalent called `ShareGroupPartitionMetadata`. Thus, I needed a new name for
the previous `ShareGroupPartitionMetadata`, but the way it works has not
changed. I will update the KIP shortly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
