gharris1727 commented on code in PR #16839:
URL: https://github.com/apache/kafka/pull/16839#discussion_r1714439487
##########
build.gradle:
##########
@@ -186,6 +186,11 @@ allprojects {
else
options.links "https://docs.oracle.com/javase/8/docs/api/";
}
+
+ clean {
Review Comment:
I wasn't aware of cleanTest, so I had to look at the documentation:
https://docs.gradle.org/current/userguide/java_plugin.html#sec:java_tasks
It seems that cleanTest means to delete the test results, which isn't quite
the right situation to use this. That would delete the generated sources, the
test results, but _not_ the test jar.
If i wanted to follow the Java plugin's conventions, i would probably add a
cleanProcessMessages and cleanProcessTestMessages and have `clean` depend on
them. Do you prefer that over applying them to `clean` directly?
Another alternative would be to move the generated sources into the `build`
directory so they get automatically cleaned up, but that's a more invasive
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
