chia7712 commented on code in PR #16839:
URL: https://github.com/apache/kafka/pull/16839#discussion_r1714489918
##########
build.gradle:
##########
@@ -186,6 +186,11 @@ allprojects {
else
options.links "https://docs.oracle.com/javase/8/docs/api/";
}
+
+ clean {
Review Comment:
> It seems that cleanTest means to delete the test results, which isn't
quite the right situation to use this. That would delete the generated sources,
the test results, but not the test jar
`cleanTest` is used to re-run the test
(https://docs.gradle.org/current/userguide/java_testing.html#sec:forcing_java_tests_to_run),
and so running `./gradlew cleanTest xxx:test` can encounter same issue: there
are generated testing code left by other branches.
> If i wanted to follow the Java plugin's conventions, i would probably add
a cleanProcessMessages and cleanProcessTestMessages and have clean depend on
them. Do you prefer that over applying them to clean directly?
`cleanProcessMessages` and `cleanProcessTestMessages` are more readable to
me, so +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
