chia7712 commented on code in PR #16841:
URL: https://github.com/apache/kafka/pull/16841#discussion_r1715067054
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -244,7 +244,7 @@ public enum MetadataVersion {
* <strong>Think carefully before you update this value. ONCE A METADATA
VERSION IS PRODUCTION,
* IT CANNOT BE CHANGED.</strong>
*/
- public static final MetadataVersion LATEST_PRODUCTION = IBP_3_8_IV0;
+ public static final MetadataVersion LATEST_PRODUCTION = IBP_3_9_IV0;
Review Comment:
> Christo's PR seems to have caused some tests to fail because of this
(https://github.com/apache/kafka/pull/15673#issuecomment-2104306940). So, I was
wondering why the failure didn't show up here.
the CI is gone so I can't see "which test" you discussed. According to
https://github.com/apache/kafka/commit/53276b12c57f325fc62e0133eae1eae023c3b74b,
I guess the test case is `testApiVersionsRequestIncludesUnreleasedApis`. It
is used to verify the api key and version range. Everything is good but #15761
introduced a "wrong" config to it. However, the test was not failed since we
did not have "unstable" version yet.
That is why #15673 changed the `unstable.api.versions.enable` from `false`
to `true`, because it added a unstable "version=0" to LIST_OFFSET.
In short, I feel the test case
`testApiVersionsRequestIncludesUnreleasedApis` is NOT related to MV. If we want
to build the relationship between "unstable version" and "MV". Maybe we can add
new field to `ApiKeys` to declare the MV for the RPC having "unstable version".
And then we can add tests for following checks
1. the RPC having unstable version must declare a MV in `ApiKeys`. The MV is
equal to the release which can change the version from unstable to "stable"
2. the `MetadataVersion#LATEST_PRODUCTION` must be smaller than MV in
`ApiKeys`. That ensures `LATEST_PRODUCTION` will NOT depend on unstable
versions.
This idea does NOT impact the production code, but it increase the
complexity of updating MV/version.
@junrao WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
