junrao commented on code in PR #16841:
URL: https://github.com/apache/kafka/pull/16841#discussion_r1715730246
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -244,7 +244,7 @@ public enum MetadataVersion {
* <strong>Think carefully before you update this value. ONCE A METADATA
VERSION IS PRODUCTION,
* IT CANNOT BE CHANGED.</strong>
*/
- public static final MetadataVersion LATEST_PRODUCTION = IBP_3_8_IV0;
+ public static final MetadataVersion LATEST_PRODUCTION = IBP_3_9_IV0;
Review Comment:
> I don't think we need to tie api versions to MV at this time.
@jolshan : Just to be clear. I think the issue is that some inter broker
requests (e.g. replication) depend on MV to set the request version, not based
on supported versions returned in ApiVersion. If we have a stable MV depending
on an unstable version of an inter-broker RPC, in the default setting (with
stable MV and requests), the broker will receive a newer version of the request
that it doesn't support.
@chia7712 : For this particular case, `ListOffset` is an inter broker RPC.
In the default setting, the replication code will use v9 of `ListOffset`.
However, by default, v9 of `ListOffset` is not supported with
latestVersionUnstable set to true. So, I still don't understand why some
existing tests don't fail. We probably need to understand the testing gap. If
we have sufficient test coverage, we probably don't need additional protocols.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
